-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
salary.js.org #9761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salary.js.org #9761
Conversation
whz11
commented
May 9, 2025
•
edited
Loading
edited
- There is reasonable content on the page (see: No Content)
- I have read and accepted the Terms and Conditions
- The site content can be seen at https://whz11.github.io/salarytools/salary
I find it difficult to see how it is related to JavaScript (besides using JS as technological driver). I have to go to great lengths to justify the subdomain by saying that a JS developer could use it as a tool to increase motivation 😁 A link to the repo would be good. I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named I'll merge after we have "contact". Please keep this PR open. |
@whz11: The link to the repository https://github.com/whz11/salarytools results in a 404 error for me (it may be private). However, the suggestion "A link to the repo would be good" was intended to provide users with an opportunity to access the code and potentially reuse it. Then the CNAME in your repo still seems missing. In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work. |
Apologies, I have now set the repository https://github.com/whz11/salarytools to public, and you can view it. I've added the CNAME configuration, so it's accessible via salary.js.org/salary. |
@whz11 subdomains have to have contnet on the root-level, so it would be necessary to rename salery.html to index.html to make your page show up at https://salary.js.org bevore I can merge. |
Got it! I've renamed salery.html to index.html. |
Welcome https://salary.js.org |