Skip to content

salary.js.org #9761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

salary.js.org #9761

merged 2 commits into from
May 14, 2025

Conversation

whz11
Copy link
Contributor

@whz11 whz11 commented May 9, 2025

The site content is a Real-time Salary Calculator

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels May 9, 2025
@indus
Copy link
Member

indus commented May 9, 2025

I find it difficult to see how it is related to JavaScript (besides using JS as technological driver). I have to go to great lengths to justify the subdomain by saying that a JS developer could use it as a tool to increase motivation 😁

A link to the repo would be good.

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line salary.js.org to make it work.

I'll merge after we have "contact". Please keep this PR open.

@whz11
Copy link
Contributor Author

whz11 commented May 12, 2025

@indus
Copy link
Member

indus commented May 12, 2025

@whz11: The link to the repository https://github.com/whz11/salarytools results in a 404 error for me (it may be private). However, the suggestion "A link to the repo would be good" was intended to provide users with an opportunity to access the code and potentially reuse it.

Then the CNAME in your repo still seems missing. In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@whz11
Copy link
Contributor Author

whz11 commented May 13, 2025

Apologies, I have now set the repository https://github.com/whz11/salarytools to public, and you can view it. I've added the CNAME configuration, so it's accessible via salary.js.org/salary.

@indus
Copy link
Member

indus commented May 13, 2025

@whz11 subdomains have to have contnet on the root-level, so it would be necessary to rename salery.html to index.html to make your page show up at https://salary.js.org bevore I can merge.

@whz11
Copy link
Contributor Author

whz11 commented May 13, 2025

Got it! I've renamed salery.html to index.html.

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label May 14, 2025
@indus
Copy link
Member

indus commented May 14, 2025

Welcome https://salary.js.org

@indus indus merged commit 100ce46 into js-org:master May 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants